Could someone list out why check revision would fail? Other then the obvious reason of hashes in wrong directory.


...Ugh Fuck sorry guys, wrong place to post.

Bad hashes?

Uh, Yeah other then that, as in coding errors.

Naturally, some pasted code would help us find coding errors.

CheckRevision() shouldn't fail because you shouldn't be able to run the game without the necessary files.  The first file uses GetModuleHandle(NULL) instead of CreateFile() for the handle...Contact Blizzard Tech Support using another client that works to let them know of your problems.

Heh, I'll send you the coding but it's messy as hell.  ::)

Alrighty, here is where it gives me check revision failure.

[code]
  HF = GetHashFiles
                          Debugtxt vbYellow, "Checking hashfiles..."
                    If (checkRevision(ValueString, HF(0), HF(1), HF(2), NewMPQNumber, Checksum) = False) Then
                        frmMain.SckBnet.Close
                        AppendText LtRed, "Checkrevision failed!"
                        Exit Function
                    End If
[/code]

This is the GetHashFiles function

[code]
Public Function GetHashFiles() As String()

    Dim HashFiles(2) As String
   
        Select Case UCase(BOT_PRODUCT)
            Case "RATS", "PXES"
                HashFiles(0) = App.Path & "\STAR\starcraft.exe"
                HashFiles(1) = App.Path & "\STAR\storm.dll"
                HashFiles(2) = App.Path & "\STAR\battle.snp"
        End Select

End Function
[/code]

You showed us the call to CheckRevision. You didn't show us the code for CheckRevision or atleast where you got it from and you didn't show us the data of the variables being sent to CheckRevision.

Alright, I see.

[quote author=dlStevens link=topic=15106.msg153701#msg153701 date=1149275310]
Alrighty, here is where it gives me check revision failure.

[code]
  HF = GetHashFiles
                          Debugtxt vbYellow, "Checking hashfiles..."
                    If (checkRevision(ValueString, HF(0), HF(1), HF(2), NewMPQNumber, Checksum) = False) Then
                        frmMain.SckBnet.Close
                        AppendText LtRed, "Checkrevision failed!"
                        Exit Function
                    End If
[/code]

This is the GetHashFiles function

[code]
Public Function GetHashFiles() As String()

    Dim HashFiles(2) As String
   
        Select Case UCase(BOT_PRODUCT)
            Case "RATS", "PXES"
                HashFiles(0) = App.Path & "\STAR\starcraft.exe"
                HashFiles(1) = App.Path & "\STAR\storm.dll"
                HashFiles(2) = App.Path & "\STAR\battle.snp"
        End Select

End Function
[/code]
[/quote]

That looks off, for some reason...

Yeah, I fixed a few things that were pretty messed up, but uh now im sending 0x50 ok, but then I get IP Banned.

Then you're obviously not sending it ok.

Well, thats not necessarily true, you can get IP Banned for other reasons, it's just like saying when you spam, get IP Banned your sending 0x50 wrong. Which isn't true.

No... but, you ARE sending 0x50 wrong and getting ip banned for it. So, really, comparing this to spamming in this situation isn't really the same. You can't even spam yet. :-)

Hah, True I can't, considering I don't have any chatting events (not that matters) but hrm...So could this whole Check Revision Failure be due to my 0x50 wrong?

Wth is this, doesn't look like CheckRevision() to me!

:o :-[ ::)

That's really not helpful at all.

A bad outgoing packet construct won't have any effect on a local routine's result.

Hm alright, I'll work on it a little more, and check some other things out.

[quote author=dlStevens link=topic=15106.msg153701#msg153701 date=1149275310]
Alrighty, here is where it gives me check revision failure.

[code]
  HF = GetHashFiles
                          Debugtxt vbYellow, "Checking hashfiles..."
                    If (checkRevision(ValueString, HF(0), HF(1), HF(2), NewMPQNumber, Checksum) = False) Then
                        frmMain.SckBnet.Close
                        AppendText LtRed, "Checkrevision failed!"
                        Exit Function
                    End If
[/code]

This is the GetHashFiles function

[code]
Public Function GetHashFiles() As String()

    Dim HashFiles(2) As String
   
        Select Case UCase(BOT_PRODUCT)
            Case "RATS", "PXES"
                HashFiles(0) = App.Path & "\STAR\starcraft.exe"
                HashFiles(1) = App.Path & "\STAR\storm.dll"
                HashFiles(2) = App.Path & "\STAR\battle.snp"
        End Select

End Function
[/code]
[/quote]



*cough*

[code]
Public Sub GetHashFiles(HashFiles() As String)
   
   Select Case UCASE(BOT_PRODUCT)
   
        Case "RATS", "SEXP"
         
            HashFiles(0) = App.Path & "\STAR\starcraft.exe"
            HashFiles(1) = App.Path & "\STAR\storm.dll"
            HashFiles(2) = App.Path & "\STAR\battle.snp"

        Case Else
            Debug.Print "hmmm..?"

    End Select

Exit Sub
[/code]


another question why is it in a function your not returning nothing as GetHashFiles


[code]

HF = GetHashFiles
                          Debugtxt vbYellow, "Checking hashfiles..."
                    If (checkRevision(ValueString, HF(0), HF(1), HF(2), NewMPQNumber, Checksum) = False) Then
                        frmMain.SckBnet.Close
                        AppendText LtRed, "Checkrevision failed!"
                        Exit Function
                    End If
[/code]

don't make things harder then it should be.. -_-

[code]

                          Debugtxt vbYellow, "Checking hashfiles..."
                    If (checkRevision(ValueString, HashFiles(0), HashFiles(1), HashFiles(2), NewMPQNumber, Checksum) = False) Then
                        frmMain.SckBnet.Close
                        AppendText LtRed, "Checkrevision failed!"
                        Exit Function
                    End If

[/code]